Skip to content

Conversation

@xumix
Copy link

@xumix xumix commented May 14, 2015

subj
all tests except 1 pass

@jonorossi
Copy link
Member

Thanks for your contribution. Can you please revert your formatting only changes (e.g. changing tabs to space) as they don't match the Castle conventions.

@xumix
Copy link
Author

xumix commented May 15, 2015

Done converting to tabs, that's all I can do

@jonorossi
Copy link
Member

Thanks for fixing the tabs problem, however you've also reformatted every file you've touched, I can't sanely review 5000+ lines changed. Once that is sorted I should have a chance at reviewing it to point out things like one file with the Castle license header replaced with your own company ("Itopcase") copyright file header.

@novice3030
Copy link

+1 on that PR please merge it with master as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants